83ec5ecd36
Every route had to remember to add the business filter to every query;
nothing stopped one that forgot. The audit for this change found several
that had: the M-Pesa status re-check, the stock ledger's duplicate checks,
the daily-inventory and branch-price upserts, a cash-sale replay lookup,
several load-by-id lookups, and every populate().
- tenantGuard: a Mongoose plugin on all ten business-scoped models. Any
find/update/delete/count/distinct, or an aggregate whose first stage is
not a $match, that does not pin exactly one businessId throws
TenantScopeError before reaching the database ($in, $exists and other
operators do not count).
- crossTenant("reason", fn): the explicit, documented exemption for the
queries that must span businesses - login's email lookup, refresh and
invite-token lookups, the M-Pesa callback, the platform console and the
maintenance scripts. git grep crossTenant lists them all.
- scopedPopulate: populated branch, product and staff names are also
restricted to the business.
- Every flagged query site now names the business (or is exempted with a
reason).
- Tests: a check that every model with a businessId field carries the
guard; the guard refusing unscoped queries of every kind; and a route
sweep where business A sends business B's ids to every read route
(nothing of B's comes back) and every write route (all refused, B's
data unchanged). Test-side database inspections go through db(), an
explicit test exemption. Removing one route's business filter makes the
suite fail.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
123 lines
3.8 KiB
TypeScript
123 lines
3.8 KiB
TypeScript
import { NextRequest, NextResponse } from "next/server";
|
|
import { connectDb } from "@/lib/server/db";
|
|
import { isMpesaEnabled } from "@/lib/server/env";
|
|
import { Transaction } from "@/lib/server/models/Transaction";
|
|
import { recordSaleMovement } from "@/lib/server/stock";
|
|
import { crossTenant } from "@/lib/server/tenantGuard";
|
|
import { MpesaCallbackLog } from "@/lib/server/models/MpesaCallbackLog";
|
|
|
|
export const runtime = "nodejs";
|
|
|
|
function getSourceIp(req: NextRequest): string {
|
|
const fwd = req.headers.get("x-forwarded-for");
|
|
if (fwd) return fwd.split(",")[0].trim();
|
|
return "unknown";
|
|
}
|
|
|
|
function isIpAllowed(ip: string): boolean {
|
|
const allowlist = process.env.DARAJA_CALLBACK_IP_ALLOWLIST;
|
|
if (!allowlist) return true;
|
|
return allowlist.split(",").map((s) => s.trim()).includes(ip);
|
|
}
|
|
|
|
export async function POST(req: NextRequest) {
|
|
if (!isMpesaEnabled()) return NextResponse.json({ error: "Not found" }, { status: 404 });
|
|
await connectDb();
|
|
const ack = () => NextResponse.json({ ResultCode: 0, ResultDesc: "Accepted" });
|
|
const sourceIp = getSourceIp(req);
|
|
|
|
let payload: any;
|
|
try {
|
|
payload = await req.json();
|
|
} catch {
|
|
await MpesaCallbackLog.create({
|
|
sourceIp,
|
|
rawPayload: { unparsable: true },
|
|
processingNote: "Malformed JSON body",
|
|
});
|
|
return ack();
|
|
}
|
|
|
|
const callback = payload?.Body?.stkCallback;
|
|
const checkoutRequestId: string | undefined = callback?.CheckoutRequestID;
|
|
const resultCode: number | undefined = callback?.ResultCode;
|
|
const resultDesc: string = callback?.ResultDesc ?? "";
|
|
|
|
if (!isIpAllowed(sourceIp)) {
|
|
await MpesaCallbackLog.create({
|
|
sourceIp,
|
|
checkoutRequestId: checkoutRequestId ?? null,
|
|
resultCode: resultCode ?? null,
|
|
rawPayload: payload,
|
|
processingNote: "Rejected: source IP not in DARAJA_CALLBACK_IP_ALLOWLIST",
|
|
});
|
|
return ack();
|
|
}
|
|
|
|
if (!checkoutRequestId) {
|
|
await MpesaCallbackLog.create({
|
|
sourceIp,
|
|
rawPayload: payload ?? {},
|
|
processingNote: "No CheckoutRequestID in payload",
|
|
});
|
|
return ack();
|
|
}
|
|
|
|
let mpesaReceiptNumber: string | null = null;
|
|
if (resultCode === 0 && callback.CallbackMetadata?.Item) {
|
|
const items: { Name: string; Value: string | number }[] = callback.CallbackMetadata.Item;
|
|
const receiptItem = items.find((i: any) => i.Name === "MpesaReceiptNumber");
|
|
mpesaReceiptNumber = receiptItem ? String(receiptItem.Value) : null;
|
|
}
|
|
|
|
const txn = await crossTenant("the payment provider's callback is matched by checkout id", () =>
|
|
Transaction.findOne({ "mpesaDetails.checkoutRequestId": checkoutRequestId }).exec()
|
|
);
|
|
|
|
if (!txn) {
|
|
await MpesaCallbackLog.create({
|
|
sourceIp,
|
|
checkoutRequestId,
|
|
resultCode: resultCode ?? null,
|
|
rawPayload: payload,
|
|
processingNote: "No matching transaction for CheckoutRequestID",
|
|
});
|
|
return ack();
|
|
}
|
|
|
|
if (txn.paymentStatus !== "PENDING") {
|
|
await MpesaCallbackLog.create({
|
|
sourceIp,
|
|
checkoutRequestId,
|
|
resultCode: resultCode ?? null,
|
|
matchedTransactionId: txn._id,
|
|
rawPayload: payload,
|
|
processingNote: "Ignored: transaction already " + txn.paymentStatus,
|
|
});
|
|
return ack();
|
|
}
|
|
|
|
const newStatus = resultCode === 0 ? "SUCCESS" : "FAILED";
|
|
txn.paymentStatus = newStatus;
|
|
txn.mpesaDetails.resultCode = resultCode ?? null;
|
|
txn.mpesaDetails.resultDesc = resultDesc;
|
|
txn.mpesaDetails.receiptNumber = mpesaReceiptNumber;
|
|
await txn.save();
|
|
await recordSaleMovement(txn);
|
|
|
|
await MpesaCallbackLog.create({
|
|
sourceIp,
|
|
checkoutRequestId,
|
|
resultCode: resultCode ?? null,
|
|
matchedTransactionId: txn._id,
|
|
rawPayload: payload,
|
|
processingNote: "Applied: transaction set to " + newStatus,
|
|
});
|
|
|
|
return ack();
|
|
}
|
|
|
|
export async function GET() {
|
|
return NextResponse.json({ error: "Method not allowed" }, { status: 405 });
|
|
}
|