83ec5ecd36
Every route had to remember to add the business filter to every query;
nothing stopped one that forgot. The audit for this change found several
that had: the M-Pesa status re-check, the stock ledger's duplicate checks,
the daily-inventory and branch-price upserts, a cash-sale replay lookup,
several load-by-id lookups, and every populate().
- tenantGuard: a Mongoose plugin on all ten business-scoped models. Any
find/update/delete/count/distinct, or an aggregate whose first stage is
not a $match, that does not pin exactly one businessId throws
TenantScopeError before reaching the database ($in, $exists and other
operators do not count).
- crossTenant("reason", fn): the explicit, documented exemption for the
queries that must span businesses - login's email lookup, refresh and
invite-token lookups, the M-Pesa callback, the platform console and the
maintenance scripts. git grep crossTenant lists them all.
- scopedPopulate: populated branch, product and staff names are also
restricted to the business.
- Every flagged query site now names the business (or is exempted with a
reason).
- Tests: a check that every model with a businessId field carries the
guard; the guard refusing unscoped queries of every kind; and a route
sweep where business A sends business B's ids to every read route
(nothing of B's comes back) and every write route (all refused, B's
data unchanged). Test-side database inspections go through db(), an
explicit test exemption. Removing one route's business filter makes the
suite fail.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
109 lines
3.7 KiB
TypeScript
109 lines
3.7 KiB
TypeScript
import { NextRequest, NextResponse } from "next/server";
|
|
import { z } from "zod";
|
|
import { connectDb } from "@/lib/server/db";
|
|
import { Expense, EXPENSE_CATEGORIES } from "@/lib/server/models/Expense";
|
|
import { Branch } from "@/lib/server/models/Branch";
|
|
import { objectId } from "@/lib/server/validation";
|
|
import { authorize, branchParam, MANAGERS } from "@/lib/server/auth";
|
|
import { scopedPopulate } from "@/lib/server/tenantGuard";
|
|
|
|
export const runtime = "nodejs";
|
|
export const dynamic = "force-dynamic";
|
|
|
|
// GET /api/expenses?branchId=&from=&to=
|
|
// Managers and owners only. SUPER_ADMIN sees all (optionally filtered by
|
|
// branch); a BRANCH_MANAGER is hard-scoped to their own branch.
|
|
export async function GET(req: NextRequest) {
|
|
await connectDb();
|
|
const gate = authorize(req, MANAGERS);
|
|
if (!gate.ok) return gate.response;
|
|
const auth = gate.auth;
|
|
|
|
const url = new URL(req.url);
|
|
const scope = branchParam(auth, url.searchParams.get("branchId"));
|
|
if (!scope.ok) return scope.response;
|
|
const scopeBranch = scope.branchId;
|
|
|
|
const filter: Record<string, unknown> = { businessId: auth.businessId };
|
|
if (scopeBranch) filter.branchId = scopeBranch;
|
|
|
|
const from = url.searchParams.get("from");
|
|
const to = url.searchParams.get("to");
|
|
if (from || to) {
|
|
const createdAt: Record<string, Date> = {};
|
|
if (from) createdAt.$gte = new Date(from);
|
|
if (to) createdAt.$lte = new Date(to);
|
|
filter.createdAt = createdAt;
|
|
}
|
|
|
|
const expenses = await Expense.find(filter)
|
|
.populate(scopedPopulate("branchId", "branchName", auth.businessId))
|
|
.populate(scopedPopulate("recordedBy", "name", auth.businessId))
|
|
.sort({ createdAt: -1 })
|
|
.limit(500)
|
|
.lean();
|
|
|
|
return NextResponse.json({ expenses });
|
|
}
|
|
|
|
const createSchema = z.object({
|
|
branchId: objectId.optional(),
|
|
category: z.enum(EXPENSE_CATEGORIES),
|
|
amount: z.number().positive().max(100_000_000),
|
|
description: z.string().trim().min(1).max(300),
|
|
reference: z.string().trim().max(80).optional(),
|
|
notes: z.string().trim().max(500).optional(),
|
|
});
|
|
|
|
// POST /api/expenses — managers and owners only, and only against a branch
|
|
// they are allowed to touch.
|
|
export async function POST(req: NextRequest) {
|
|
await connectDb();
|
|
const gate = authorize(req, MANAGERS);
|
|
if (!gate.ok) return gate.response;
|
|
const auth = gate.auth;
|
|
|
|
const json = await req.json().catch(() => null);
|
|
const parsed = createSchema.safeParse(json);
|
|
if (!parsed.success) {
|
|
return NextResponse.json(
|
|
{ error: parsed.error.issues[0]?.message ?? "Invalid request" },
|
|
{ status: 400 }
|
|
);
|
|
}
|
|
|
|
// Resolve the branch this expense is booked against, then enforce scope.
|
|
let branchId: string | null;
|
|
if (auth.role === "SUPER_ADMIN") {
|
|
branchId = parsed.data.branchId ?? null;
|
|
if (!branchId) {
|
|
return NextResponse.json({ error: "branchId is required" }, { status: 400 });
|
|
}
|
|
} else {
|
|
branchId = auth.branchId;
|
|
// A scoped user may not book an expense onto another branch.
|
|
if (parsed.data.branchId && parsed.data.branchId !== auth.branchId) {
|
|
return NextResponse.json({ error: "Cannot record for another branch" }, { status: 403 });
|
|
}
|
|
}
|
|
|
|
// The target branch MUST belong to this tenant.
|
|
const branch = await Branch.findOne({ _id: branchId, businessId: auth.businessId }).lean();
|
|
if (!branch) {
|
|
return NextResponse.json({ error: "Branch not found in your business" }, { status: 404 });
|
|
}
|
|
|
|
const expense = await Expense.create({
|
|
businessId: auth.businessId,
|
|
branchId,
|
|
category: parsed.data.category,
|
|
amount: parsed.data.amount,
|
|
description: parsed.data.description,
|
|
reference: parsed.data.reference ?? null,
|
|
notes: parsed.data.notes ?? null,
|
|
recordedBy: auth.sub,
|
|
});
|
|
|
|
return NextResponse.json({ expense }, { status: 201 });
|
|
}
|